Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib-bloop: transitive unmanaged classpath are not included in runtime classpath #4031

Open
yoohaemin opened this issue Nov 26, 2024 · 2 comments

Comments

@yoohaemin
Copy link

val runtimeClasspath = Task.Anon {
module.transitiveModuleDeps.map(classes) ++
module.resolvedRunIvyDeps().map(_.path) ++
module.unmanagedClasspath().map(_.path)
}

This doesn't contain the unmanagedClasspath jars of the module being depended on.

Workaround (for me): the depending module can override its unmanagedClasspath to manually include everything.

@lefou
Copy link
Member

lefou commented Nov 27, 2024

I would say, since it's "unmanaged", it's reasonable for you to manage it manually and don't have some defaults, which may break someones else workflow.

@yoohaemin
Copy link
Author

Hmm, but the current behavior is different between mill and bloop when running the app. With mill, it runs fine (all classpath jars are present), with bloop it crahes with (in my case) NoClassDefFoundError.

I also find it hard to imagine the kind of situation where adding a transitive jar to bloop output (making the classpath complete) can actually break a workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants