Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse of IUserIdGenerator? #16

Open
jensens opened this issue Nov 13, 2015 · 0 comments
Open

Reuse of IUserIdGenerator? #16

jensens opened this issue Nov 13, 2015 · 0 comments
Labels

Comments

@jensens
Copy link
Member

jensens commented Nov 13, 2015

"Keep in mind that plone.app.users already makes use of IUserIdGenerator and ILoginNameGenerator utilities (https://github.com/plone/plone.app.users/blob/master/plone/app/users/browser/interfaces.py#L20) so please consider whether the ones you're adding here duplicate that functionality." (by @davisagli in #12)

Some research needed if this makes sense in some way, at a first look this has some side effects.

@jensens jensens changed the title Make reuse of IUserIdGenerator? Reuse of IUserIdGenerator? Nov 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant