Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with dateutil timezones [Python, guided by maintainer] #691

Open
3 tasks
niccokunzmann opened this issue Jul 9, 2024 · 4 comments
Open
3 tasks

Test with dateutil timezones [Python, guided by maintainer] #691

niccokunzmann opened this issue Jul 9, 2024 · 4 comments
Labels
feature good first issue hacktoberfest Issues for participation in the hacktoberfest https://hacktoberfest.com/

Comments

@niccokunzmann
Copy link
Member

At the moment, we check icalendar with zoneinfo and pytz.
We can also make sure that dateutil works.

  • create a TimzoneProvider for dateutil
  • parametrize the tests to work with dateutil (conftest.py)
  • add possible additional tests
@niccokunzmann niccokunzmann added feature good first issue hacktoberfest Issues for participation in the hacktoberfest https://hacktoberfest.com/ labels Jul 9, 2024
@c0d33ngr
Copy link
Contributor

c0d33ngr commented Jul 9, 2024

I'll work on this

@devdanzin
Copy link
Contributor

We (@mtrd3v and I) are working on this.

@niccokunzmann
Copy link
Member Author

niccokunzmann commented Oct 14, 2024

@devdanzin @c0d33ngr @mtrd3v Thanks for taking this on! Please create a PR with some changes to indicate progress and work as soon as you have only a little bit done. Then, you can collaborate, review and inspire.
We can do many PRs and not everything has to be done perfectly in one go. You might also want to work on the same branch together. This is actually a big issue, so you will need each other for quality.

I do not lock issues or tell people they cannot contribute because someone else said that they would.
Happy coding and collaborating!

@mtrd3v
Copy link
Contributor

mtrd3v commented Oct 14, 2024

I have created a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature good first issue hacktoberfest Issues for participation in the hacktoberfest https://hacktoberfest.com/
Projects
None yet
Development

No branches or pull requests

4 participants