You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If plone/plone.recipe.codeanalysis#219 isn't accepted, do you think it's feasible to create a hacky command in qa.cfg using a zc.recipe.command? A variable namedpylint-py3k-pre-commit-hook can be created in qa.cfg (false by default) and a little zc.recipe.command snippet:
[buildout]
index = https://pypi.org/simple/
package-min-coverage = 80
pylint-py3k-pre-commit-hook = false
parts +=
code-analysis
i18ndude
pylint-py3k
pylint-py3k-pre-commit-hook
(...)
[pylint-py3k]
recipe = zc.recipe.egg
eggs =
pylint
${buildout:eggs}
[pylint-py3k-pre-commit-hook]
recipe = plone.recipe.command
stop-on-error = yes
command =
pre_commit_file="${buildout:directory}/.git/hooks/pre-commit"
if ${buildout:pylint-py3k-pre-commit-hook}; then
if ! grep -q 'py3k' "$pre_commit_file"; then
echo "\nbin/pylint --py3k --disable=no-absolute-import ${code-analysis:directory}" >> "$pre_commit_file"
fi
fi
# XXX: Else is getting 'not found' when executed. Don't know why so I'm using two ifs.if ! ${buildout:pylint-py3k-pre-commit-hook}; then
sed -i '/py3k/d' "$pre_commit_file"
fi
The text was updated successfully, but these errors were encountered:
If plone/plone.recipe.codeanalysis#219 isn't accepted, do you think it's feasible to create a hacky command in qa.cfg using a zc.recipe.command? A variable named
pylint-py3k-pre-commit-hook
can be created inqa.cfg
(false
by default) and a little zc.recipe.command snippet:The text was updated successfully, but these errors were encountered: