Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Might need changes in qa.cfg for i18ndude #32

Open
mauritsvanrees opened this issue Mar 6, 2018 · 2 comments
Open

Might need changes in qa.cfg for i18ndude #32

mauritsvanrees opened this issue Mar 6, 2018 · 2 comments

Comments

@mauritsvanrees
Copy link
Member

Yesterday I released i18ndude 5. This requires zope.tal 4.3.0 as minimum. This may cause an error on Travis for Plone 4. See https://travis-ci.org/smcmahon/Products.PloneFormGen/jobs/348254762:

While:
  Installing i18ndude.
Error: The requirement ('zope.tal>=4.3.0') is not allowed by your [versions] constraint (3.5.2)

PloneFormGen branch 1.7-maintenance has this in travis.cfg:

[buildout]
extends =
    https://raw.github.com/collective/buildout.plonetest/master/travis-4.x.cfg
    https://raw.github.com/collective/buildout.plonetest/master/qa.cfg

I would expect that the i18ndude pin would be taken over from travis-4.x.cfg which should in the end take the pin from http://dist.plone.org/release/4.3-latest/versions.cfg, which actually pins it to 4.0.1. So I don't yet get why it gets the newer 5.0.1 version.

For now, I have fixed it in PloneFormGen by pinning i18ndude to 4.3.

If more builds from add-ons start failing, we may need to take action. It would be a pity to pin it to version 4.3 for all builds though: Plone 5 should get the latest.

@hvelarde
Copy link
Member

hvelarde commented Mar 6, 2018

I think the problem is the way the caching is set up in that repository; the travis.cfg has an outdated method that is not using the container cache, but a fixed cache. at some point you may have been downloaded the new version of i18ndude and it's now stored in the cache directory.

on the other side I don't know why the pinning is not there.

@idgserpro
Copy link
Member

@mauritsvanrees I think the ideal here is to allow the use of i18ndude of system.

You need to define an i18ndude_path variable in rebuild_i18n-sh part. This variable may have the default value bin/i18ndude, but it must be possible to override it in another cfg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants