-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microformat #44
Comments
which part to add microformat? |
hey @arifsetyo21 i'm hoping to add as much coverage as makes sense, so that includes author information, post information, website information. it would be great if as part of this issue, the person who takes it tries to figure out what all make sense |
Okay, can i do this issue? |
sure thing :) let me know if you have any issues! |
I don't know if this belongs in this issue but it would be good to have everything required for webmentions leveraging of microformats in here. |
(I'll find a link!) |
yes! that was one of the things i had in mind when thinking about it. it would be cool as that information is valuable for services that can provide a rich experience and if im not mistaken even search engines use it |
hey @arifsetyo21 checking in - are you having any luck with this? |
unassigning this to allow someone else to work on it |
@colbyfayock I'll take this up if no one else is working on it. Also, I think this issue should be split in two as there could be too many changes at once. |
@Azanul sounds good to me! would love to hear your thoughts then before moving forward including the work that needs to be done and what you see as the 2 issues |
@colbyfayock I meant 2 PRs as there can be many changes. |
Got it, I would still like 2 issues to have concise details around the problems each are solving so that we're not creating 2 PRs for the sake of creating 2 PRs |
@colbyfayock I've read about microformats now. What I understood is we'll have to add appropriate class names to all components, right? |
from what i understand i think thats part of it. i was also under the impression there would be more attributes than classes, such as "roles" and such, but i haven't looked too deeply into it |
You mean adding |
yeah haha that might be it! :D i trust whatever you find out through your research |
Let's divide it in either of these two ways:
|
i don't think it makes sense to create a new PR for every component, but if you'd like to break up the work another way, such as one for pages and one for components, I'm open to that |
Not one PR for each component but one for half of them and another for other half |
let's do pages vs components as that sounds a little bit like a more logical difference /src/pages that sound good? |
By vs you mean one PR for pages and one for components right? |
Let me take up components then |
yup, sounds great |
We should add logical microformats throughout the site
http://microformats.org/
https://microformats.io/
https://developer.mozilla.org/en-US/docs/Web/HTML/microformats
The text was updated successfully, but these errors were encountered: