Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass extra args to underlying http-client #199

Open
kkrausse opened this issue Dec 8, 2021 · 1 comment
Open

Pass extra args to underlying http-client #199

kkrausse opened this issue Dec 8, 2021 · 1 comment

Comments

@kkrausse
Copy link

kkrausse commented Dec 8, 2021

Dependencies

{:deps {com.cognitect.aws/api       {:mvn/version "0.8.292"}
        com.cognitect.aws/endpoints {:mvn/version "1.1.11.532"}
        com.cognitect.aws/s3        {:mvn/version "714.2.430.0"}}}

Enhancement Description

I'm using the api with a custom HttpClient, and I'd like the ability to pass http-client-specific arguments to this client on a per-request bases. I see this being an extra field in the op-map that gets propagated to the request so it can be used by the underlying HttpClient. Right now I'm only able to achieve this by monkey-patching the cognitect.aws.interceptors/modify-http-request methods.

@fogus
Copy link
Contributor

fogus commented Dec 8, 2021

Hello! Thank you for the ticket. We're planning the possibilities around a bring-your-own client mode but have not landed on a solution yet. The underlying mechanisms certainly allow for injections your own (as you proved) but they should not be relied on to stay the same into the future. To that point I would hesitate to make changes to allow options pass through for now until a formal approach to bring-your-own is designed and implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants