Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Enhanced routers #5

Open
dextercodo opened this issue Mar 23, 2024 · 1 comment
Open

Feat: Enhanced routers #5

dextercodo opened this issue Mar 23, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dextercodo
Copy link
Contributor

dextercodo commented Mar 23, 2024

Current behaviour:

  • Router struct currently has Echo as a property.
  • Additional methods are currently scattered around in handlers, helpers and routers.

Expected behaviour:

  • Router should embed Echo instead, and takes a new context struct that embeds echo's context.
  • Move all helpers to new context so that handlers have all they need within the context parsed.
@dextercodo dextercodo self-assigned this Mar 23, 2024
@dextercodo dextercodo added enhancement New feature or request good first issue Good for newcomers labels Mar 23, 2024
@dextercodo dextercodo assigned dextercodo and unassigned dextercodo Mar 23, 2024
@dextercodo
Copy link
Contributor Author

Started implementing a custom context

  • Moved all functions from handlers/handlers.go to new custom context
  • Moved all functions from handlers/helpers.go to the new context
  • Created new validator under helpers. this is intended to be added to echo router
  • Updated all handlers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant