Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kanban Set-up for Final Capstone Project #12

Open
coderacheal opened this issue Aug 18, 2023 · 2 comments
Open

Kanban Set-up for Final Capstone Project #12

coderacheal opened this issue Aug 18, 2023 · 2 comments

Comments

@coderacheal
Copy link
Owner

Hi reviewer, This is a team of 4consisting of @coderacheal @Ouail-01 @brhanuhailu @Atifzada
Link to our project here
image

@Meltrust
Copy link

Meltrust commented Aug 18, 2023

Hi @coderacheal

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

To highlight:

  • All cards have been assigned✔️

You can do it

Required Changes ♻️

image

However, many of your kanban board's tasks lack a description:

image

Therefore, please, kindly add descriptions to all your tasks. Ensure all of them have descriptions.

That way, we will meet this particular requirement.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Meltrust
Copy link

Hi @coderacheal,

Wow, you did it 🎉

Brilliant

Thank you for implementing the changes requested by the previous reviewer 💪 🥇 ㊗️

Well done!

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

To highlight

  • All cards now have descriptions✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants