-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create a new "Install Dev Container feature" module #307
Comments
I have created an issue over @ the Envbuilder repo to discuss how we could maybe add a command that would use the existing feature logic. |
Do you want this to work on any workspace or only with an existing devcontainer spec? |
All workspaces. |
@phorcys420 The devcontainer feature script should be intelligent enough to exist cleanly if it is incompatible with the workspace image. As per my experience, most devcontainer features are only compatible with Debian/ubuntu images. |
I agree, usually devcontainer features already handle that and most of our users are using Debian/Ubuntu anyways, but we can probably wrap it in a try/catch or something just to exit cleanly. |
I think we should have an easy way to install Dev Container features in Coder workspaces (even outside of Dev Containers).
My reasoning behind that is that there is already a lot of great Dev Container features that you are currently unable to use with Coder without hacks.
There are also quite a lot of active modules that are used to maintain dependencies and collide w/ Coder modules (e.g
nodejs
andjupyterlab
).Given these points, I think we could replace part of our modules with existing Dev Container features and maybe migrate some of our existing features to contribute back to the Dev Container ecosystem.
Example usage
The text was updated successfully, but these errors were encountered: