Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace loose comparisons #22

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Dec 17, 2023

Description

  • replace loose comparisons

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

I'm only wondering why changes applied to the pop() method in the Predis handler aren't added to the Redis handler as well.

@kenjis
Copy link
Member Author

kenjis commented Dec 18, 2023

phpstan-strict-rules did not report errors.

$this->predis->zrangebyscore() returns only array.
But $this->redis->zRangeByScore() returns array|false|Redis.
That is the reason?

@michalsn
Copy link
Member

Yes, most likely. Thanks.

@michalsn michalsn merged commit b9df900 into codeigniter4:develop Dec 18, 2023
11 checks passed
@kenjis kenjis deleted the refactor-loose-comparisons branch December 18, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants