Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the verbose mode (-v) supposed to let the clear-text token into the output of codecov -v create-commit? #469

Closed
webknjaz opened this issue Jul 1, 2024 · 0 comments · Fixed by #485
Assignees
Labels
bug Something isn't working

Comments

@webknjaz
Copy link
Contributor

webknjaz commented Jul 1, 2024

Here https://github.com/pytest-dev/pytest/actions/runs/9746387730/job/26896668869?pr=12553#step:9:66 I noticed that one debug log entry has it sanitized, and the other reveals the token value within an escaped JSON string. I haven't attempted debugging why this is happening, but it seems it might be related to said escaping.
It's not very problematic in this specific project, though.

P.S. Your own dogfooding step @ https://github.com/codecov/codecov-cli/actions/runs/9715039688/job/26815507245#step:6:2 does not manifest this problem since it only invokes do-upload and doesn't run create-commit as the action wrapper does.
P.P.S. Many people use ${{ secrets.CODECOV_TOKEN }} in the GHA realm, so GHA masks the value for them, on a different level. But when the value is not coming from a secret, it's not hidden by the platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants