Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support golang 1.9 #18

Open
siebertm opened this issue Oct 14, 2017 · 3 comments
Open

Support golang 1.9 #18

siebertm opened this issue Oct 14, 2017 · 3 comments
Assignees

Comments

@siebertm
Copy link

We have a go 1.9 project which uses type aliases. The current codeclimate-golint version does not seem to support golang 1.9:

Could not lint file: /code/hl7/hl7.go
Error /code/hl7/hl7.go:13:14: expected type, found '=' (and 4 more errors)

The respective line is

type Segment = hl7.Segment

Can the engine be updated to support that?

@wfleming
Copy link
Contributor

Hi @siebertm,

Thanks for the report. We've just released a new version of this plugin that should have an updated version of golint: if you're using codeclimate.com you should be getting analysis from the new version already. If you're using our CLI, you'll need to run codeclimate engines:install to get the new version.

Please let me know if the new version is working better for you.

@levinalex
Copy link

#19 does not fix this issue, because to support Go 1.9, golint has to be compiled with Go 1.9. (and alpine:3.4 does not ship with Go 1.9. (looks like even alpine 3.6 only has Go 1.8.3)

@levinalex
Copy link

levinalex commented Oct 18, 2017

there is golang:1.9-alpine, which might work as a base image. (Dockerfile)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants