Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating an NGO as Admin does not work #38

Closed
danniel opened this issue Apr 20, 2019 · 2 comments
Closed

Updating an NGO as Admin does not work #38

danniel opened this issue Apr 20, 2019 · 2 comments

Comments

@danniel
Copy link
Collaborator

danniel commented Apr 20, 2019

The code for updating an NGO first checks if the user already has an NGO. If the user has no NGO, then a new one is created. If the user already has an NGO, then that organisation is updated.

The problem is that there doesn't seem to be any way for the Admin account to edit another NGO. When one tries to update an existing organisation, the code tries to create a new NGO because the Admin has no NGO.

@cnstlungu
Copy link

Thanks @danniel .

@onel I would think this issue is no longer actual given the changes we've made for #28 .
Updating an NGO as an admin should be done solely through the Admin interface. Opinions?

@onel
Copy link
Member

onel commented Jul 27, 2019

@danniel thanks for finding this and taking the time to create a PR.
It fixes the issue, but as @cnstlungu said, we have moved all the admin functionality to a different part of the app. It was hacky the way it was done up to now.
Closing this issue

@onel onel closed this as completed Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants