Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Report #57

Open
howlbot-integration bot opened this issue Oct 27, 2024 · 2 comments
Open

QA Report #57

howlbot-integration bot opened this issue Oct 27, 2024 · 2 comments
Labels
bug Something isn't working grade-b Q-07 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality

Comments

@howlbot-integration
Copy link

howlbot-integration bot commented Oct 27, 2024

See the markdown file with the details of this report here.

@howlbot-integration howlbot-integration bot added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality labels Oct 27, 2024
howlbot-integration bot added a commit that referenced this issue Oct 27, 2024
howlbot-integration bot added a commit that referenced this issue Oct 27, 2024
@c4-judge
Copy link

c4-judge commented Nov 4, 2024

GalloDaSballo marked the issue as grade-b

@GalloDaSballo
Copy link

| L-1 | Use of assert Statements in Production Code |
I
| L-2 | Embedding Modifier in Private Function Reduces Contract Size |
I
| NC-1 | Incorrect Inline Documentation in Timelock::atIndex Function |
I
| NC-2 | Inefficient Gas Usage in getCalldataChecks Function |
-3
| NC-3 | Redundant require Check in Timelock Contract |
-
| NC-4 | Unnecessary Type Casting in Constants.sol |
TODO
| NC-5 | Unused Imports in TimelockFactory |
TODO
| NC-6 | Unnecessary eq Usage in Inline Assembly in RecoverySpell.sol |
TODO
| NC-7 | Unnecessary Loading of State Variable in Timelock.sol |
TODO
| NC-8 | Solidity Naming Convention Violation |
TODO

Ignoring rest 0

@C4-Staff C4-Staff added the Q-07 label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working grade-b Q-07 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax sufficient quality report This report is of sufficient quality
Projects
None yet
Development

No branches or pull requests

3 participants