Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

labhub: IGitt breakage replaced username strings with User objects #633

Open
jayvdb opened this issue Oct 24, 2018 · 0 comments
Open

labhub: IGitt breakage replaced username strings with User objects #633

jayvdb opened this issue Oct 24, 2018 · 0 comments
Assignees
@jayvdb
Labels
area/labhub hoster/github hoster/gitlab importance/critical

Comments

@jayvdb
Copy link
Member

jayvdb commented Oct 24, 2018

IGitt's Issue.assign() and Issue.unassign() now take a FooUser object instead of a username.

Our tests use mocks so they didnt notice this.

Constructing a User object isnt exactly easy either.
The User objects are using for logging in, and as a result require a token parameter in the constructor.
@jayvdb jayvdb assigned jayvdb and unassigned jayvdb Oct 26, 2018
jayvdb added a commit to jayvdb/corobo that referenced this issue Oct 26, 2018
@jayvdb
labhub: Fetch IGitt user objects
b4d9a83 
Issue.assign and Issue.unassign now require a User object
instead of the username.

Closes coala#633
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jayvdb jayvdb

Labels
area/labhub hoster/github hoster/gitlab importance/critical
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jayvdb