Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultConfigMixin needs 100% branch coverage #609

Open
jayvdb opened this issue Aug 8, 2018 · 5 comments
Open

DefaultConfigMixin needs 100% branch coverage #609

jayvdb opened this issue Aug 8, 2018 · 5 comments

Comments

@jayvdb
Copy link
Member

jayvdb commented Aug 8, 2018

The directory utils was omitted from coverage, and so this work was not completed to the coala standard.

utils/mixin.py 26 20 14 0 15% 7-9, 12-15, 18-22, 25-38
@gitmate-bot gitmate-bot added the bug label Aug 8, 2018
@jayvdb jayvdb removed the bug label Aug 8, 2018
@jayvdb
Copy link
Member Author

jayvdb commented Aug 8, 2018

(rechecking this ... looks like those numbers are wrong)

@jayvdb
Copy link
Member Author

jayvdb commented Aug 8, 2018

Looks like it is 15, 14->15, 21->exit

@jayvdb
Copy link
Member Author

jayvdb commented Aug 8, 2018

Actually only 21->exit

https://travis-ci.org/jayvdb/corobo/builds/413532424

jayvdb added a commit to jayvdb/corobo that referenced this issue Aug 9, 2018
@jayvdb
mixin.py: Add pragma no cover for default branch
0c4a507 
A default branch is needed to ensure branch coverage.
'pragma: no cover' is used as a temporary workaround.

Related to coala#611
Related to coala#609
jayvdb added a commit to jayvdb/corobo that referenced this issue Aug 9, 2018
@jayvdb
mixin.py: Add pragma no cover for default branch
3e422ca 
A default branch is needed to ensure branch coverage.
'pragma: no cover' is used as a temporary workaround.

Related to coala#611
Related to coala#609
jayvdb added a commit to jayvdb/corobo that referenced this issue Aug 9, 2018
@jayvdb
mixin.py: Add pragma no cover for default branch
415894f 
A default branch is needed to ensure branch coverage.
'pragma: no cover' is used as a temporary workaround.

Related to coala#611
Related to coala#609
jayvdb added a commit to jayvdb/corobo that referenced this issue Aug 9, 2018
@jayvdb
mixin.py: Add pragma no cover for default branch
e6d3bdd 
A default branch is needed to ensure branch coverage.
'pragma: no cover' is used as a temporary workaround.

Related to coala#611
Related to coala#609
jayvdb added a commit to jayvdb/corobo that referenced this issue Aug 9, 2018
@jayvdb
mixin.py: Add pragma no cover for default branch
5230ff4 
A default branch is needed to ensure branch coverage.
'pragma: no cover' is used as a temporary workaround.

Related to coala#611
Related to coala#609
@jayvdb jayvdb assigned jayvdb and unassigned nvzard Aug 9, 2018
@jayvdb
Copy link
Member Author

jayvdb commented Aug 9, 2018

Given time is running short, I'll do this one

@jayvdb
Copy link
Member Author

jayvdb commented Aug 9, 2018

actually the next patch will do it automatically I believe.

@jayvdb jayvdb removed their assignment Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jayvdb @gitmate-bot @nvzard