Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LabHub is_room_member a private function of the module #602

Open
jayvdb opened this issue Aug 5, 2018 · 3 comments
Open

Make LabHub is_room_member a private function of the module #602

jayvdb opened this issue Aug 5, 2018 · 3 comments

Comments

@jayvdb
Copy link
Member

jayvdb commented Aug 5, 2018

LabHub.is_room_member is unnecessarily a static method of the class.

It can be moved to a private function _is_room_member at the module level, and then the tests can be improved to remove the need to do special plugin mocking.

See #572 (comment) for context

@srivama
Copy link

srivama commented Aug 17, 2018

Assign this to me.

@kumar1202
Copy link
Member

@jayvdb Can you assign it to me, if no one is working on it.

@srivama
Copy link

srivama commented Oct 11, 2018

Ah yes! I was working on this issue earlier, but then it skipped my mind after the exams break. Feel free to work on it once you’re assigned 🙂

@jayvdb jayvdb assigned kumar1202 and unassigned srivama Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants