Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh mats #63

Open
pshriwise opened this issue Jan 31, 2019 · 0 comments
Open

Mesh mats #63

pshriwise opened this issue Jan 31, 2019 · 0 comments

Comments

@pshriwise
Copy link
Member

I was reviewing #56 and I'm a little confused as to what the mats data structure is intended to be...

By default it looks like an empty tuple, but the documentation states it should be a MaterialLibrary or dict of mats (typo in docstring there) mapping volume element handles to materials. Here we're mapping indices to materials.

I see that the materials object always gets set to a valid dictionary-like object unless mats is None, indicating that the user doesn't want materials on the mesh.

  • I think that at some point we should figure out what's up with the keys for the mats property. I'm thinking it's just a docstring update? 🤞

  • I'll also advocate for the default of mats to be an empty dictionary (or MaterialLibrary) to reduce confusion about what the data structure ends up being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant