Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect url generation for members in <a> hyperlink #878

Open
Btijmen opened this issue Apr 19, 2023 · 3 comments
Open

Incorrect url generation for members in <a> hyperlink #878

Btijmen opened this issue Apr 19, 2023 · 3 comments

Comments

@Btijmen
Copy link

Btijmen commented Apr 19, 2023

This issue applies to both the CNCF and LFAI landscapes, and I believe this is the result of url-generation in this upsteam app.

What happens?

The url in the a element for the members header is incorrect. On click the element functions as expected, but when opened in a new tab the link leads to a 404.

This happens in the members page when clicking the category link for silver/gold/platinum (CNCF) or associate/general/premier (LFAI) respectively. For clarity, here's a screen shot of the cncf page with the offending link highlighted in a red box:

Screenshot 2023-04-19 at 14 01 24

The hyperlink element looks like this:

<a data-type="internal" href="/card?category=platinum&amp;grouping=category" style="[abridged for legibility]">Platinum</a>

The href part is wrong, and should redirect to /card-mode rather than card.

This seems like a very simple fix and I'd be happy to fix it myself, but I have absolutely no experience in NodeJS and have been unable to find exactly where in the code this has to be fixed. If someone can either fix this, or direct me to the file that needs to be edited, that'd be much appreciated.

@AndreyKozlov1984
Copy link
Contributor

Thank you, great catch!

@RipulHandoo
Copy link

@Btijmen It seems that the issue you raised on April 19, 2023, has been resolved. Since there have been no further comments or activity on the issue, and based on my own testing, I believe the problem has been resolved by the programmers of the company.

I suggest closing this issue as it no longer requires any action. Please review and consider closing the issue. Thank you!

@Btijmen
Copy link
Author

Btijmen commented Jun 1, 2023

It has not been resolved. Try opening the 'platinum' link in a new tab on this page: https://landscape.cncf.io/members?category=app-definition-and-development&grouping=category

You will find a 404, because the href url is not generated correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants