Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup links and sources to serve from non-root URL #848

Open
Boojapho opened this issue Nov 1, 2022 · 3 comments
Open

Setup links and sources to serve from non-root URL #848

Boojapho opened this issue Nov 1, 2022 · 3 comments

Comments

@Boojapho
Copy link

Boojapho commented Nov 1, 2022

Currently, all of the landscape app links and sources are absolute paths from the root of the URL. For example, a logo is pulled from /logos/mylogo.svg. This works fine if you are hosting from the root (e.g. https://landscape.cncf.io). However, if a user creates a landscape and attempts to host it from https://my.org/landscape/, the links and source are broken. The logo source would be https://my.org/logos/mylogo.svg, but it sits at https://my.org/landscape/logos/mylogo.svg on the server.

Can you make the links relative to index.html rather than absolute?

@Boojapho Boojapho changed the title Setup links to serve from non-root URL Setup links and sources to serve from non-root URL Nov 1, 2022
@Boojapho
Copy link
Author

Boojapho commented Nov 1, 2022

By setting PROJECT_NAME, you can workaround this limitation. If I set PROJECT_NAME to landscape all of my source/links are generated relative to /landscape/*. We have our staging area at a different path than production, so this still requires us to rebuild the website, to promote to production.

@IRSHIT033
Copy link

I have read the issue carefully Can You assign this to me.

@ashutosh887
Copy link

@Boojapho Let me work on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants