Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addExternalInfo.js loses crunchbase data from processed landscape #835

Open
danielsilverstone-ct opened this issue Jul 25, 2022 · 1 comment · May be fixed by #836
Open

addExternalInfo.js loses crunchbase data from processed landscape #835

danielsilverstone-ct opened this issue Jul 25, 2022 · 1 comment · May be fixed by #836

Comments

@danielsilverstone-ct
Copy link

I am trying to render a landscape locally for test purposes. Unfortunately when I attempt to run a render, during yarn fetch, specifically at the addExternalInfo.js step, all the crunchbase data from the processed landscape is lost, despite the output saying:

CRUNCHBASE_KEY_4 is not set. Using processed_landscape.yml as a source for crunchbase info

I'm pretty sure this didn't happen when I first tried playing with Landscapeapp, though perhaps it always had. Either way, this isn't very helpful when I need to run builds locally to test the effect of changes to landscapeapp and want to ensure I'm not breaking official landscapes in doing so.

Is there a convenient way for me to ensure that the already cached data is not lost so that I can render these landscapes locally?

@danielsilverstone-ct
Copy link
Author

Sorry for the noise, I have discovered the bug, introduced in 933ac23 we no longer retain the saved crunchbase data if the key is not set. I shall file a PR to fix this immediately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant