Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset for kitchen environment #35

Open
CeHao1 opened this issue Jun 28, 2023 · 3 comments
Open

Dataset for kitchen environment #35

CeHao1 opened this issue Jun 28, 2023 · 3 comments

Comments

@CeHao1
Copy link

CeHao1 commented Jun 28, 2023

Hi Kpertsch, thanks for providing the SPiRL code and Maze dataset.
I find you updated the closed-loop model for the kitchen environment. How did you generate the dataset for it?

In D4RL, I find a script to generate kitchen data, but I am not sure if it is correct.
https://github.com/kpertsch/d4rl/blob/master/scripts/generate_kitchen_datasets.py

Thanks.
Best, Ce

@CeHao1 CeHao1 closed this as completed Jun 28, 2023
@kpertsch
Copy link
Collaborator

Hi Ce,

Not sure whether this is still a problem since you closed the issue, but we're just using the default kitchen dataset provided by D4RL -- you can see how it's downloaded and processed in this file: https://github.com/clvrai/spirl/blob/master/spirl/data/kitchen/src/kitchen_data_loader.py

Note that the dataset does not need to change when switching to the closed-loop model.

-- Karl

@CeHao1
Copy link
Author

CeHao1 commented Jun 29, 2023

Thanks, Karl, I understand how to use the kitchen dataset now.
BTW, it seems the SKilD paper https://arxiv.org/pdf/2107.10253.pdf, Appendix F changed the target environment of the kitchen.
Do we have instructions about this change? For example, in the Skild repo https://github.com/clvrai/skild.

Best,
Ce

@CeHao1 CeHao1 reopened this Jun 29, 2023
@kpertsch
Copy link
Collaborator

Hi Ce,

Yes, it's straightforward to change the task in the Kitchen environment.

You can define new versions of the Kitchen environment with different target tasks like here: https://github.com/kpertsch/d4rl/blob/21743171daf2094379b91dfb74bf7c15049b729f/d4rl/kitchen/kitchen_envs.py#L132

Then register the new version of the kitchen environment with gym: https://github.com/kpertsch/d4rl/blob/21743171daf2094379b91dfb74bf7c15049b729f/d4rl/kitchen/__init__.py#L45

And then in the SkiLD codebase we can switch the used version of the Kitchen environment like here: https://github.com/clvrai/skild/blob/91868b1fb1460e7e9013711bd01a047fc7a8ec7b/skild/configs/demo_rl/kitchen/conf.py#L185

-- Karl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants