-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use official php alpine image #20
Conversation
I took a quick look at mssql with php7, apparently there is a few options but I don't know which works or not:
anyone knows which one would work ? |
@kusmierz well, as you've seen when trying with php 7, supports for the mssql extension was dropped and it seems it's now harder to use php with mssql on linux. I'm looking at how to install odbc or pdo_odbc but they needs some dependencies I don't know how to get and I don't even know if those are enough to support mssql servers (I've never worked with mssql) so either I figure out how to install odbc extension and someone can confirm it's enough or we have to stick with with php 5.6 (that would be a PITA) @clue alternatively how about another branch (and another tag on docker hub) for alpine until everything is supported properly? it would be easier for others to test the alpine branch and would not break everyone still using |
@mathroc @kusmierz Regarding mssql and odbc: I would focus on the main features. Adminer was mainly written with MySQL in mind. So if this works, I'd say the main job is done. Anything else is bonus. It can either be added in a later release. Or if someone really needs it, he can build his own image using this here as a base image.
I wonder if we couldn't also use the apache based official image. Not sure if alpine is really worth the extra hassle. The thing with alpine images is, that even the official PHP image is not that much smaller than the debian/apache based. In that case we would also not need |
closing in favor of #21 |
I'm not opposed to getting another branch set up in the meantime 👍 I think we agree that the goal should be an image that is as easy to use as possible, so a single branch should probably be our (perhaps mid term) goal here.
I understand where you're coming from and personally have yet to use this image with MSSQL. However, there are people that use this image with alternative databases (#7), so I'm not a big fan of dropping this for merely this:
So far we're only talking about an optimization (which I think is a good thing!). I agree, personally I'm not yet convinced this alone warrants dropping features, so I'm curious how #21 will end up 👍 |
this Dockfile is based on php:7.0-alpine and does not install nginx, fpm or apache. it only use
php -S
. It seems to works fine with the very basic test I'v done connecting to a postgresql database.please share your thoughts on this and test it if you can
todo:
/ping @mikehaertl