Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom labels #7

Open
botzill opened this issue Mar 4, 2019 · 7 comments
Open

Allow custom labels #7

botzill opened this issue Mar 4, 2019 · 7 comments
Labels
enhancement New feature or request
Milestone

Comments

@botzill
Copy link

botzill commented Mar 4, 2019

I was thinking about this custom labels definition. For example on DigitalOcean we have node pool name in nodes label as:

screen shot 2019-03-04 at 14 48 58

Now, this can be used as node pool in dashboard directly.

Is there any way todo this ?

Thx, great work!!

@weeco weeco added the enhancement New feature or request label Mar 5, 2019
@weeco
Copy link
Member

weeco commented Mar 5, 2019

I like the idea. I'll look into it :-).

@dir01
Copy link

dir01 commented Jul 24, 2019

Apparently (kubernetes/kops#5767), right now kops (or kubernetes itself) does not allow custom node names. My current workflow with grafana dashboard now looks like this: I run kubectl get nodes -l kops.k8s.io/instancegroup=spot-nodes, and then manually limit results to given nodes, one at a time. As you can imagine, it gets painful rather fast (╯°□°)╯︵ ┻━┻

Is there anything one could do to help make this a reality?

@weeco
Copy link
Member

weeco commented Jul 24, 2019

This feature is still at the top of my todo list for this project, but unfortunately I haven't had enough time to work on it yet. Pull requests for this however are welcome.

Other than that I am still eager to implement this on my own as well - my usecases would benefit by this feature as well :).

@dir01
Copy link

dir01 commented Jul 24, 2019

Could you please briefly describe how one would go about implementing this?

@dir01
Copy link

dir01 commented Jul 28, 2019

What I finally came up with is this:

image

@weeco weeco added this to the v2 milestone Oct 26, 2019
@troytoman
Copy link

This would make it much more useful on AWS EKS as well. Node names do not include any useful information.

@liorfranko
Copy link

Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants