Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set disable for module cause issue with recovery points #60

Open
fdavier opened this issue Nov 16, 2023 · 1 comment
Open

set disable for module cause issue with recovery points #60

fdavier opened this issue Nov 16, 2023 · 1 comment
Labels
invalid This doesn't seem right

Comments

@fdavier
Copy link

fdavier commented Nov 16, 2023

Describe the Bug

if i set disable on module by adding count parameter. when i execute my terraform code. terraform try to delete backup vault but it failed because it containing recovery points

Expected Behavior

should be able to set count to 0. apply terraform and see backup vault destroyed without issue

Steps to Reproduce

set count to 0 o backup vault with recovery point inside and apply terraform

Screenshots

Screenshot 2023-11-16 at 14 33 18

Environment

actual module deploy in our environments 0.7.1
aws = {
source = "hashicorp/aws"
version = "5.16.1"
}
and terraform 1.0.0

Additional Context

No response

@fdavier fdavier added the bug 🐛 An issue with the system label Nov 16, 2023
@Nuru Nuru added invalid This doesn't seem right and removed bug 🐛 An issue with the system labels Mar 22, 2024
@Nuru
Copy link

Nuru commented Mar 22, 2024

It is intentional that the module will not destroy backups with recovery points by default, or by setting count = 0.

We will address this by adding a force_destroy option you can enable that will handle this case, along the same lines as how we handle this for S3 buckets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants