Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): add upload icon into icon lib #302

Merged
merged 7 commits into from
Sep 6, 2024
Merged

fix(ui): add upload icon into icon lib #302

merged 7 commits into from
Sep 6, 2024

Conversation

VoigtS
Copy link
Contributor

@VoigtS VoigtS commented Sep 4, 2024

Summary

During my development duties I noticed that Juno offers a Download Icon, but no Upload Icon. I would like to include it.

  • Add the Icon from the material-design lib
  • Bump the juno version

Screenshots (if applicable)

image

Testing Instructions

Open the Storybook, navigate to the Icon section, View the Upload Icon

Copy link

changeset-bot bot commented Sep 4, 2024

🦋 Changeset detected

Latest commit: 094b9bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-ui-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 4, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://cloudoperators.github.io/juno/pr-preview/pr-302/
on branch gh-pages at 2024-09-06 08:14 UTC

@VoigtS VoigtS marked this pull request as ready for review September 4, 2024 16:08
@VoigtS VoigtS requested review from franzheidl and a team as code owners September 4, 2024 16:08
Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you would like to introduce new Icon to the Icon.js I would suggest to do the same for IconTs cause we are currently in a migration phase that try to migrate the whole components to TS for that reason please also implement this functionality in IconTS.component.ts

@VoigtS
Copy link
Contributor Author

VoigtS commented Sep 5, 2024

If you would like to introduce new Icon to the Icon.js I would suggest to do the same for IconTs cause we are currently in a migration phase that try to migrate the whole components to TS for that reason please also implement this functionality in IconTS.component.ts

Thank you for the info, I included the icon in the Ts implementation as well.

@VoigtS VoigtS requested a review from barsukov September 5, 2024 09:44
@barsukov barsukov enabled auto-merge (squash) September 5, 2024 14:51
@barsukov barsukov merged commit ea09b68 into main Sep 6, 2024
6 of 7 checks passed
@barsukov barsukov deleted the upload_icon branch September 6, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants