-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): add upload icon into icon lib #302
Conversation
🦋 Changeset detectedLatest commit: 094b9bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you would like to introduce new Icon to the Icon.js I would suggest to do the same for IconTs cause we are currently in a migration phase that try to migrate the whole components to TS for that reason please also implement this functionality in IconTS.component.ts
Thank you for the info, I included the icon in the Ts implementation as well. |
Summary
During my development duties I noticed that Juno offers a
Download
Icon, but noUpload
Icon. I would like to include it.Screenshots (if applicable)
Testing Instructions
Open the Storybook, navigate to the Icon section, View the
Upload
Icon