fix(ui): forward button title to icon #301
Merged
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation always inserted the icon name into its title, disregarding the button title
🦋 Changeset detectedLatest commit: 83c3a2a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
VoigtS
changed the title
VoigtS
changed the title
|
VoigtS
changed the title
barsukov
requested changes
Sep 5, 2024
packages/ui-components/src/components/Button/Button.component.js
Outdated
Show resolved
Hide resolved
edda
requested changes
Sep 5, 2024
packages/ui-components/src/components/Button/Button.component.js
Outdated
Show resolved
Hide resolved
edda
previously approved these changes
Sep 6, 2024
barsukov
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The previous implementation always inserted the icon name into its title, disregarding the button title.
Changes Made
In this screenshot, the Icon was hovered with a custom title set on the button.
Testing Instructions
Open the storybook. Add a custom title on the button, hover over the Icon for a few seconds until the title shows up.