Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(infra): unify config package #278

Merged
merged 11 commits into from
Aug 28, 2024
Merged

Conversation

barsukov
Copy link
Contributor

@barsukov barsukov commented Aug 27, 2024

Summary

Many lilttle leftovers but very important ones, fix main brunch typecheck.

Changes Made

  • Delete eslintconfig package
  • FIX OAUTH leftovers types
  • Fix docs
  • Add typecheck CI
  • Change k8s output
  • Delete tsconfig package
  • create juno-config pacakge
  • Changesets

Related Issues

Testing Instructions

  1. npm i
  2. npm run TASK

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@barsukov barsukov added the bug Something isn't working label Aug 27, 2024
@barsukov barsukov self-assigned this Aug 27, 2024
@barsukov barsukov requested review from franzheidl and a team as code owners August 27, 2024 13:08
Copy link

changeset-bot bot commented Aug 27, 2024

🦋 Changeset detected

Latest commit: d7884ba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@cloudoperators/juno-oauth Patch
@cloudoperators/juno-k8s-client Patch
@cloudoperators/juno-url-state-provider Patch
@cloudoperators/juno-messages-provider Patch
@cloudoperators/juno-url-state-router Patch
@cloudoperators/juno-ui-components Patch
@cloudoperators/juno-communicator Patch
@cloudoperators/juno-template Patch
@cloudoperators/juno-config Patch
@cloudoperators/juno-utils Patch
@cloudoperators/juno-app-template Patch
@cloudoperators/juno-app-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 27, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-08-28 11:57 UTC

packages/config/README.md Outdated Show resolved Hide resolved
packages/config/README.md Outdated Show resolved Hide resolved
packages/config/README.md Outdated Show resolved Hide resolved
@barsukov barsukov requested a review from edda August 27, 2024 14:42
@barsukov barsukov enabled auto-merge (squash) August 28, 2024 07:18
Copy link
Collaborator

@ArtieReus ArtieReus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@andypf andypf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barsukov barsukov merged commit 8c06648 into main Aug 28, 2024
15 checks passed
@barsukov barsukov deleted the chore/wowa-unify-config-package branch August 28, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants