feat(scanner): add keppel scanner #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorneanu
reviewed
Aug 20, 2024
scanner/keppel/main.go
Outdated
| wg.Wait() | ||
| } | ||
|
|
||
| func ProcessAccount(account models.Account, keppelScanner *scanner.Scanner, keppelProcessor *processor.Processor, wg *sync.WaitGroup) error { |
There was a problem hiding this comment.
We might consider refactoring this function into smaller ones (processRepositories, processManifests etc.) as it's already huge with lots of for-loops.
drochow
reviewed
Aug 20, 2024
scanner/keppel/main.go
Outdated
| log.SetOutput(os.Stdout) | ||
|
|
||
| // Only log the warning severity or above. | ||
| log.SetLevel(log.DebugLevel) |
dorneanu
reviewed
Aug 22, 2024
| @@ -1,3 +1,35 @@ | |||
| module github.com/cloudoperators/heureka/scanners/keppel | |||
There was a problem hiding this comment.
Is there a policy when to use github.com and when to use github.wdf.sap.com (like here: https://github.com/cloudoperators/heureka/blob/scanner_nvd/scanner/nvd/go.mod#L1) ?
drochow
approved these changes
Aug 22, 2024
dorneanu
pushed a commit
that referenced
this pull request
Aug 26, 2024
* feat(scanner): init keppel scanner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.