Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(heureka): corrects URL state handling for filter property #375

Closed
hodanoori opened this issue Nov 13, 2024 · 0 comments
Closed

fix(heureka): corrects URL state handling for filter property #375

hodanoori opened this issue Nov 13, 2024 · 0 comments
Assignees

Comments

@hodanoori
Copy link

hodanoori commented Nov 13, 2024

After the refactoring of filters and the list controller, selected filters for different views were no longer preserved in the URL state. This prevented sharing deep links, as the recipient couldn't open the app with the same view, selected tab, and filters. This fix restores proper URL state handling for consistent deep linking.

The issue occurred because activeFilters was mistakenly omitted from the input parameters of FilterSelect, causing the selected filters to not be reflected in the URL state. This prevented accurate deep linking. The fix ensures activeFilters is properly passed, restoring correct URL state handling.

@hodanoori hodanoori self-assigned this Nov 13, 2024
@hodanoori hodanoori changed the title fix(heureka): fixes filter property in url state handling fix(heureka): corrects URL state handling for filter property Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants