Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sso logout uses different endpoint #4949

Open
2 tasks done
cache-sk opened this issue Jul 2, 2021 · 0 comments
Open
2 tasks done

Sso logout uses different endpoint #4949

cache-sk opened this issue Jul 2, 2021 · 0 comments
Labels
community Community Raised Issue

Comments

@cache-sk
Copy link

cache-sk commented Jul 2, 2021

Stratos Version

4.4.0 release

Frontend Deployment type

  • Cloud Foundry Application (cf push)

Backend (Jet Stream) Deployment type

  • Cloud Foundry Application (cf push)

Expected behaviour

Sso logout should probably use same endpoint as sso login.

Actual behaviour

When SSO is activated, login uses /sso_login which in method initSSOlogin in file authuaa.go redirects to p.Config.ConsoleConfig.AuthorizationEndpoint

Logout uses /sso_logout which in method ssoLogoutOfUAA also in file authuaa.go redirects to p.Config.ConsoleConfig.UAAEndpoint.

I think, this should be redirected to same endpoint.

Can i ask, why are there two endpoints, which looks like it should be same? I have noticed this because in our test cf enviroment somebody configured authorization_endpoint to https://login.something and token_endpoint to https://uaa.something, which both points to the same Uaa, but due different domains, user is never logged out from login domain (browser flow cookies).

Also, I didn't find anywhere in docs, that there must be logout in SSO_OPTIONS enviroment atribute, to activate sso logout, and if SSO_ALLOWLIST is used, it must contain logout too, because only logout and not full url is used as state in callback after logout - this is probably bug too.

@richard-cox richard-cox added the community Community Raised Issue label Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community Raised Issue
Projects
None yet
Development

No branches or pull requests

2 participants