Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communication misconfiguration in code #4904

Open
1 of 9 tasks
anugu-vijaykanth opened this issue Apr 12, 2021 · 0 comments
Open
1 of 9 tasks

Communication misconfiguration in code #4904

anugu-vijaykanth opened this issue Apr 12, 2021 · 0 comments
Labels
community Community Raised Issue

Comments

@anugu-vijaykanth
Copy link

anugu-vijaykanth commented Apr 12, 2021

Stratos Version

4.4.0

Frontend Deployment type

  • Cloud Foundry Application (cf push)
  • Kubernetes, using a helm chart
  • Docker, single container deploying all components
  • npm run start
  • Other (please specify below)

Backend (Jet Stream) Deployment type

  • Cloud Foundry Application (cf push)
  • Kubernetes, using a helm chart
  • Docker, single container deploying all components
  • Other (please specify below)

Expected behaviour

Transmit all sensitive data over a TLS connection with validated certificates. This includes all communications with browsers that contain sensitive pages. It also includes all backend connections with databases, servers, and other services.

Example Code
telnet.ListenAndServeTLS(":5556", "cert.pem", "key.pem", handlers)

Actual behaviour

The application does not use a secure channel, such as TLS, to exchange sensitive information or avoids validating a certificate. Therefore, it is possible for an attacker with network traffic access to sniff packets from the connection and uncover the data or provide a altered certificate to perform a man-in-the-middle attack. This attack is not technically difficult, but does require physical access to some portion of the network over which the sensitive data travels. This access is usually somewhere near where the user is connected to the network (such as a colleague on the company network) but can be anywhere along the path from the user to the end server.

This can be a few things under Golang:

Settings that allow insecure certificate checks.
Insecure communication functions.
Example Code
HostKeyCallback: ssh.InsecureIgnoreHostKey()
conf := &tls.Config{ InsecureSkipVerify: true}

telnet.DialToAndCall("example.net:5555", caller)

Steps to reproduce the behavior

same issue found in few file paths
cfmr-ui\src\jetstream\main.go:782
cfmr-ui\src\jetstream\plugins\cloudfoundry\cf_websocket_streams.go:119
cfmr-ui\src\jetstream\plugins\kubernetes\terminal\start.go:118

Log output covering before error and any error statements

Insert log hereCopy

Detailed Description

There is a miss communication in Golang code

Context

Possible Implementation

@richard-cox richard-cox added the community Community Raised Issue label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community Raised Issue
Projects
None yet
Development

No branches or pull requests

2 participants