You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the COGNITO_CLIENT.config.region which is a CognitoIdentityProviderClientResolvedConfig is able to return either a string, or a Provider<string>. The latter returns the promise of a string.
I'm not sure of the motivation behind using the resolved config, but seeing as we're feeding it from environment variables I suggest accessing that instead, because handling the choice of a string or a promise seems like unnecessary effort.
The text was updated successfully, but these errors were encountered:
elliotsegler
added a commit
to elliotsegler/cloudcomponents-cdk-constructs
that referenced
this issue
May 26, 2024
The user-pool-domain lambda is generating invalid configuration.json which contain a busted domain name like below
I believe the faulting line is this one:
cdk-constructs/packages/cdk-cloudfront-authorization/src/lambdas/user-pool-domain/index.ts
Line 31 in 60f1d89
the
COGNITO_CLIENT.config.region
which is aCognitoIdentityProviderClientResolvedConfig
is able to return either a string, or aProvider<string>
. The latter returns the promise of a string.I'm not sure of the motivation behind using the resolved config, but seeing as we're feeding it from environment variables I suggest accessing that instead, because handling the choice of a string or a promise seems like unnecessary effort.
The text was updated successfully, but these errors were encountered: