Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error propagation issues obfuscating root causes #42

Open
Alfus opened this issue Jun 7, 2023 · 2 comments
Open

Error propagation issues obfuscating root causes #42

Alfus opened this issue Jun 7, 2023 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@Alfus
Copy link

Alfus commented Jun 7, 2023

We are seeing errors like:

found no matching overload for _?_:_ applied to '(<class 'celpy.evaluation.CELEvalError'>, <class 'celpy.celtypes.StringType'>, <class 'celpy.celtypes.StringType'>)'", <class 'TypeError'>, ("Unexpected <class 'celpy.evaluation.CELEvalError'> ? <class 'celpy.celtypes.StringType'> : <class 'celpy.celtypes.StringType'>

Which is obfuscating the underlying error that occured in the argument to conditional.

This appears to be happening because the arguments to both registered and builtin functions are not being checked before passed in as celtypes.Value. Ideally 'strict' functions would have all the arguments sanctity checked, and any errors in the arguments would be propagated instead of invoking the function, while the logical operators, && and ||, and built in '@not_strictly_false` should be tolerant of some errors in the arguments.

@kapilt
Copy link
Collaborator

kapilt commented Jul 22, 2023

pull requests welcome

@slott56 slott56 added the help wanted Extra attention is needed label May 21, 2024
@slott56
Copy link
Collaborator

slott56 commented May 21, 2024

It's not perfectly clear (to me) what the benchmark Go implementation does in this case.

I'm unclear on where the Go implementation does type-checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants