Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple instances failures #39

Open
stecca21 opened this issue Mar 13, 2023 · 1 comment
Open

multiple instances failures #39

stecca21 opened this issue Mar 13, 2023 · 1 comment

Comments

@stecca21
Copy link

Although I can create multiple instances only the settings of the first instance are actually reviewed.

I have 2 different instances set up. Both use filtering. Instance 2 has a different filter and points to a different channel than instance 1.

Instance,channel,filter
1,1,1
2,2,2

If instance 1 is the only instance enabled anything that satisfies the filter in 1 results in two slack notifications to channel 1.
If instances 1 and 2 are enabled anything that satisfies the filter in 1 results in two slack notifications to channel 1.
If instance 2 is the only instance enabled anything that satisfies the filter in 2 does not result in a slack notification being sent.

I have confirmed that my filter in instance 2 is not the issue by testing it in instance 1 of the plugin.
I have confirmed that my slack endpoint in instance 2 is not the issue by testing it in instance 1 of the plugin.

Looking at the code the bootstrap() function is always going to return the first active plugin instance because it's passing a null value to getPluginInstance.

@joshin42
Copy link

joshin42 commented May 31, 2023

I've encountered this too.

The first instance runs, not the second. And it is sorted on the instance name.

In my case, I'm trying to post to both Slack and Discord
-J

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants