Fix: Use correct config #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her places than bootstrap the default config and not the configured values will be returned. Fixes clonemeagain#61
|
This fixes an issue on 1.17.5 and 1.18 where the plugin fails to install and/or crashes osTicket, suggest this fix be merged, however underlying issue with pdf (audio and video as well) not implementing still present, likely in .js |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getConfig() mehtod only works correctly in the bootstrap method of the plugin.
In all other mehtods, it will only return the default configuration, which causes #61
This PR will save the correct configuration in a static variable during the bootstrap call and override the getConfig method to return that variable, if it is set.
The only thing where this could cause problems is if you have multiple instances of this plugin, which is a new feature of OsTicket (where I have no idea for a use case), but I cannot imagine a useful scenario where you would need multiple instances of the Attachment Preview Plugin.