Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize decompilation step #3

Open
clabe45 opened this issue Dec 31, 2021 · 0 comments
Open

Optimize decompilation step #3

clabe45 opened this issue Dec 31, 2021 · 0 comments
Labels
help wanted Extra attention is needed performance Optimization

Comments

@clabe45
Copy link
Owner

clabe45 commented Dec 31, 2021

Currently, the decompilation step (found in minecraft/source.py) is a bit slow. The decompilation step has three steps:

  1. Decompile the sources in .DecompilerMC or .yarn (depending on the project config)
  2. Delete any existing sources in the user's repo
  3. Move the new sources to the user's repo

We could try a few things to optimize this process:

  • Skip step 3 by using DecompilerMC to generate the client and server sources jars and extracting their contents directly to the user's repo ourselves
  • Find a faster decompiler (but most of the decompilers are pretty slow)
  • Cache Minecraft versions #20
@clabe45 clabe45 added the performance Optimization label Dec 31, 2021
@clabe45 clabe45 added the help wanted Extra attention is needed label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed performance Optimization
Projects
None yet
Development

No branches or pull requests

1 participant