Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error checker when creating cmd queue in client: especially when OoO queue is not supported on many devices #354

Open
tingxingdong opened this issue Apr 20, 2021 · 1 comment

Comments

@tingxingdong
Copy link
Contributor

By default , the client created a out-of-orer queue. However, most devices only support in-order queue. The main purpose of client is to test clBLAS maths functions not test queues. It is better to change into in-order queue by default.

https://github.com/clMathLibraries/clBLAS/blob/master/src/client/clfunc_common.hpp#L306

@tingxingdong
Copy link
Contributor Author

tingxingdong commented Apr 28, 2021

An error checker should be inserted, even certain property queue is not supported, error can be caught much earlier.

@@ -304,6 +304,7 @@ public:

         OPENCL_V_THROW(err, "creating context");
         for (unsigned int i = 0; i < numQueues; i++) {
           queues_[i] = clCreateCommandQueue(ctx_, device_, CL_QUEUE_OUT_OF_ORDER_EXEC_MODE_ENABLE, &err);
+          OPENCL_V_THROW(err, "create command queue");
         }

@tingxingdong tingxingdong changed the title client should use in-order queue rather than out-of-order queue by default add error checker when creating cmd queue in client: especially when OoO queue is not supported on many devices May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant