GraphQL fetcher should honor headers from headers editor #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whew, this just a week shy of a year old! We've been using this change in production for a year and haven't had any issues. |
|
@ciscorn , can you help me figure out if there's a path forward to getting this PR merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #28.
Seems like this library uses an ancient GraphiQL setup. This PR updates some of that on the way to supporting making the headers editor work appropriately.
It tries to follow the "out of the box" implementation here https://github.com/graphql/graphiql/blob/main/examples/graphiql-cdn/index.html#L60, as referenced in this GraphiQL issue related to missing headers: graphql/graphiql#3005 (comment)
It seems like subscriptions are handled within
GraphiQLthese days, so the couple of subscription packages have been removed. They are also no longer supported and have been archived on github:In my local testing this seems to work well, but it's worth noting that my test apps don't leverage subscriptions so there could be something askew in that regard. Any feedback is welcome.