Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions are not catched when using a websocket #17

Open
pjotterplotter opened this issue Jul 6, 2021 · 0 comments · Fixed by #18
Open

Exceptions are not catched when using a websocket #17

pjotterplotter opened this issue Jul 6, 2021 · 0 comments · Fixed by #18

Comments

@pjotterplotter
Copy link

pjotterplotter commented Jul 6, 2021

It catches exceptions over http now #13 is resolved, but it is still swallows exceptions when subscribing / sending the query over a websocket:

app.mount("/graphql", graphql_app)
app.add_websocket_route("/graphql-ws", graphql_app)

Another suggestion would be to be able to mask the error details in the graphql response, so using logging getting the full error message, but return a generic error message over the graphql connection, so sensitive data cannot leak that way?

@ciscorn ciscorn linked a pull request Jul 7, 2021 that will close this issue
@ciscorn ciscorn reopened this Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants