Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the GWS Policy API #481

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Add support for the GWS Policy API #481

wants to merge 6 commits into from

Conversation

buidav
Copy link
Collaborator

@buidav buidav commented Oct 24, 2024

🗣 Description

  • Add support for the GWS Policy API buy embedding the results of the API call in the ScubaResults.json
  • Using policy API code instead of Python Client library until that is fixed (May want to keep using this?) Fixed in v2.151.0

💭 Motivation and context

Closes #480

🧪 Testing

  • Follow the new README directions to enable the Cloud Identity API and delete/regenerate the token.json file that is created.
  • Run scubagoggles with any product. The policy API will always be called when ScubaGoggles is run.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@buidav buidav added this to the Driftwood milestone Oct 24, 2024
@buidav buidav self-assigned this Oct 24, 2024
@buidav buidav linked an issue Oct 24, 2024 that may be closed by this pull request
@buidav buidav marked this pull request as ready for review October 24, 2024 23:33
@buidav buidav requested a review from rlxdev October 24, 2024 23:34
@buidav buidav marked this pull request as draft October 31, 2024 21:15
@buidav buidav removed their assignment Nov 5, 2024
@buidav buidav removed this from the Driftwood milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the GWS Policy API
1 participant