Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Rule Instructions for Common Controls 13.1 #497

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Updating Rule Instructions for Common Controls 13.1 #497

wants to merge 2 commits into from

Conversation

mdueltgen
Copy link
Collaborator

@mdueltgen mdueltgen commented Nov 7, 2024 •
edited
Loading

🗣 Description

Clarified required actions to meet the baseline requirements.

Updated to skip straight to the actions page by just clicking the "Actions" box, which would cut out two steps.

💭 Motivation and context

Closes #467

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@mdueltgen mdueltgen added this to the Driftwood milestone Nov 7, 2024
@mdueltgen mdueltgen linked an issue Nov 7, 2024 that may be closed by this pull request
Clarify rules instructions #467
Open
2 tasks
adhilto
adhilto requested changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@adhilto adhilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just one small grammatical tweak.

baselines/commoncontrols.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhilto adhilto adhilto approved these changes

@buidav buidav buidav approved these changes

@jkaufman-mitre jkaufman-mitre Awaiting requested review from jkaufman-mitre

Assignees

@mdueltgen mdueltgen

Labels
Baseline Revision Common Controls
Projects
None yet
Milestone
Driftwood
Development

Successfully merging this pull request may close these issues.

Clarify rules instructions
4 participants
@mdueltgen @buidav @adhilto @jkaufman-mitre