Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Workflow: Devices with non-standard Ports #29

Open
1 of 13 tasks
makermelissa opened this issue Oct 19, 2022 · 3 comments
Open
1 of 13 tasks

Web Workflow: Devices with non-standard Ports #29

makermelissa opened this issue Oct 19, 2022 · 3 comments
Labels
Testing Needs to Be tested Web Workflow

Comments

@makermelissa
Copy link
Collaborator

makermelissa commented Oct 19, 2022

This may or may not be an issue. I need to test when all Web Workflow devices are on ports other than 80 to see if it works.

With 1 device set up with port 8080:

With 2 or more devices set up with port 8080:

With 1 device set up with port 8080 and 1 device set up with port 80:

@makermelissa
Copy link
Collaborator Author

Ok, when I set the device to 8080 and browse to http://circuitpython.local/code, it doesn't find any devices. If I go to http://circuitpython.local:8080/code it loads, but results in the issue described #37. I believe device discovery should still work, but suspect going between circuitpython.org and the device might not forward to the port. I'll have to dig a bit to see the what the behavior is, because it's possible I may have had it use the hostname including the port.

@makermelissa
Copy link
Collaborator Author

This has been updated and #37 has been fixed. I'd like to do some more extensive testing. Edit the top comment of this issue and add some checkboxes for specific things I'd like to test.

@makermelissa
Copy link
Collaborator Author

Most likely some dialogs will need updated instructions (and probably the guide) as non-standard ports require a little extra work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Needs to Be tested Web Workflow
Projects
None yet
Development

No branches or pull requests

1 participant