Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC-5267 eip712Domain() for retrieval of EIP-712 domain #426

Open
frangio opened this issue Nov 9, 2023 · 0 comments
Open

Add ERC-5267 eip712Domain() for retrieval of EIP-712 domain #426

frangio opened this issue Nov 9, 2023 · 0 comments

Comments

@frangio
Copy link

frangio commented Nov 9, 2023

Circle tokens use EIP-712 signatures, but only have a DOMAIN_SEPARATOR() getter. This getter is not enough for applications to request EIP-712 signatures from users because the full domain parameters are required. The only available solution is for applications to hardcode known domain objects, which significantly limits adoption of EIP-712, and can become a problem if Circle tokens ever need to update their domain.

ERC-5267 defines a standard eip712Domain() function for contracts to publish their domain parameters so that applications can retrieve them. Please consider adding this function to Circle tokens.

For reference here is OpenZeppelin's implementation: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/v5.0.0/contracts/utils/cryptography/EIP712.sol#L114-L137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant