Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof POWERED_FLIGHT_SUBROUTINES #624

Open
wopian opened this issue Feb 20, 2020 · 9 comments · Fixed by #754 · May be fixed by #759
Open

Proof POWERED_FLIGHT_SUBROUTINES #624

wopian opened this issue Feb 20, 2020 · 9 comments · Fixed by #754 · May be fixed by #759
Assignees
Labels
Size: Small 250 to 499 lines
Milestone

Comments

@wopian
Copy link
Collaborator

wopian commented Feb 20, 2020

Proof read transcribed code of POWERED_FLIGHT_SUBROUTINES against scans

Lines: 447
Page: 1259—1267 (8)

Reduced quality scans can be found here

@wopian wopian added this to the Luminary099 milestone Feb 20, 2020
@wopian wopian added Size: Small 250 to 499 lines and removed Size: Moderate 500 to 749 lines labels Feb 20, 2020
@serialhex
Copy link
Contributor

I'm going to attempt this one if no one else is.

@only1thor
Copy link

@serialhex how's it going?
if youre tired of proofreading, ill be happy to pick up where you left off. :)

@only1thor
Copy link

only1thor commented Oct 9, 2020

I just started looking through it, and noticed on page 1262, that the word TRANSFORMED is hyphenated in the original, and not in the code here.
I assume that is an acceptable difference?
since it's a comment anyway.

Screenshot from 2020-10-09 14-18-17

@serialhex
Copy link
Contributor

Hey, sorry I didn't get back to you @tcuc I don't have reliable internet access, so I need to plan my updates accordingly. As far as I know & understand, the code should be exactly like the transcript, including misspellings. At least that's how I've been working on it.

I should have this done by the weekend sometime, maybe Monday.

@wopian
Copy link
Collaborator Author

wopian commented Oct 9, 2020

I just started looking through it, and noticed on page 1262, that the word TRANSFORMED is hyphenated in the original, and not in the code here.

This should be corrected to match the scans.

since it's a comment anyway.

The proofing is focused solely on the comments (for the most part)

@ghost
Copy link

ghost commented Oct 11, 2020

Is this still open? Is there something I can help with?

@wopian
Copy link
Collaborator Author

wopian commented Oct 11, 2020

Is this still open? Is there something I can help with?

@serialhex is already working on this

@serialhex
Copy link
Contributor

@wopian Question: I'm almost done with my transcription, but I just noticed that a lot of the code uses spaces instead of (or with) tabs in some places. Such as this:

# lines 77-80
CDUTRIGS	CA	CDUX
		TS	CDUSPOT +4	# the whitespace is a space
		CA	CDUY
		TS	CDUSPOT

and

# lines 88-93, removed comments
TR*GL**P	MASK	SIX
		TS	TEM3
		INDEX	TEM3
		CA	CDUSPOT
		DXCH	MPAC
		DXCH	VBUF 	+4	# Whitespace is a space and then a tab

There's even this:

# lines 434-437
		DXCH	MPAC 	+3	# space-tab between "MPAC" and "+3"
		DDOUBL
		INDEX 	TEM1		# space-tab between "INDEX" and "TEM1"
		DXCH	10

I don't know enough about AGC assembly to know if this is significant, but I doubt it is. Should I remove these spaces? It looks like it wouldn't mess up the alignment of the code at all, even in the first example the tab would put the +4 in the same column.

Everything else is done, I'm just curious about this whitespace issue. Thank you!

@wopian
Copy link
Collaborator Author

wopian commented Oct 12, 2020

I don't know enough about AGC assembly to know if this is significant, but I doubt it is. Should I remove these spaces? It looks like it wouldn't mess up the alignment of the code at all, even in the first example the tab would put the +4 in the same column.

Should be tabs only for the (uncommented) code itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: Small 250 to 499 lines
Projects
None yet
3 participants