Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof ORBITAL_INTEGRATION #609

Open
wopian opened this issue Feb 20, 2020 · 9 comments
Open

Proof ORBITAL_INTEGRATION #609

wopian opened this issue Feb 20, 2020 · 9 comments
Assignees
Labels
Milestone

Comments

@wopian
Copy link
Collaborator

wopian commented Feb 20, 2020

Proof read transcribed code of ORBITAL_INTEGRATION against scans

ℹ️ Multiple PRs for ~15 pages at a time are recommended!

ℹ️ This file has a low number of comments!

Lines: 977
Page: 1227—1248 (21)

Reduced quality scans can be found here

@wopian wopian added Help Wanted Size: Large 750 to 1499 lines labels Feb 20, 2020
@wopian wopian added this to the Luminary099 milestone Feb 20, 2020
@Yuri-M-Dias
Copy link

Could I get this assigned? Should probably be done by saturday.

@christian-westbrook
Copy link

Hello! Is this issue available? I'd love to try tackling it for Hacktoberfest.

@wopian
Copy link
Collaborator Author

wopian commented Nov 3, 2022

@christian-westbrook I've assigned you the issue 👍

@christian-westbrook
Copy link

I've forked the repository, and I've reviewed CONTRIBUTING.md, and I've installed the AGC Assembly in Visual Studio Code. I'm now starting to review for the first time.

@christian-westbrook
Copy link

It has been a while since I've moved on this, but I'm back at it today! I might post questions here since this is my first issue here!

@christian-westbrook
Copy link

christian-westbrook commented Jun 29, 2023

Hello! Would this count as a mistake to be fixed?

Scan:

image

Repository:

image

My intuition would tell me to change this line to:

image

I just want to make sure this is the kind of thing I'm supposed to be doing before committing to several changes. Thanks for the help!

@christian-westbrook
Copy link

Following up! I'm happy to help, just want to get acclimated to the process! @chrislgarry

@christian-westbrook
Copy link

I notice that the page numbers listed in the issue (1227—1248) do not match the pages listed in the comments of ORBITAL_INTEGRATION.agc. Should I modify the page numbers to match where they appear in your scans? In this case, the comments claim pages (1334-1354).

@StefanosL
Copy link

@christian-westbrook can you make a PR and we'll review it there?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants