Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespacing #27

Open
jbrooksuk opened this issue Jul 10, 2014 · 6 comments
Open

Namespacing #27

jbrooksuk opened this issue Jul 10, 2014 · 6 comments

Comments

@jbrooksuk
Copy link

I notice that this project was last updated 9 months ago and has several outstanding pull requests, so I'm reluctant to make this change if you're no longer maintaining this project.

To make php-diff work with Laravel, it need to be in a namespace. If I make this change, would you merge it, or should I just fork and maintain my own copy?

@JayBizzle
Copy link

@jbrooksuk I would be interested in this change. Have you done anything with it yet?

@jbrooksuk
Copy link
Author

@JayBizzle (great name by the way) - I started writing my own version, but ended up running out of time, so no progress so far.

@JayBizzle
Copy link

No worries. Might have to take a look at it myself, need it for a Laravel project soon. I'll update this thread if I get anywhere with it

@jbrooksuk
Copy link
Author

Cool, I look forward to it.

@timwhitlock
Copy link

Old thread, I know. I've been using actinarium/php-diff for namespace support in this project, but it seems abandoned and well beyond its predecessors now.

If anyone knows of a well maintained fork that is namespaced, please let me know.

@hackel
Copy link

hackel commented Dec 18, 2015

I wound up here after trying to work with https://github.com/adaptivemedia/php-text-difference that also does the same thing. We really need one brave volunteer to merge all of these forks and maintain this thing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants