New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline Style: $toLine in wrong <th> #13

Open

MathiasGmeiner opened this issue May 27, 2013 · 1 comment

MathiasGmeiner commented May 27, 2013

I have changed the $toLine placement from the left to the right in inline.php on line number 131.

From:

foreach($change['changed']['lines'] as $no => $line) {
 $toLine = $change['changed']['offset'] + $no + 1;
 $html .= '<tr>';
 $html .= '<th>'.$toLine.'</th>';
 $html .= '<th>&nbsp;</th>';
 $html .= '<td class="Right"><span>'.$line.'</span></td>';
 $html .= '</tr>';
}

To:

foreach($change['changed']['lines'] as $no => $line) {
 $toLine = $change['changed']['offset'] + $no + 1;
 $html .= '<tr>';
 $html .= '<th>&nbsp;</th>';
 $html .= '<th>'.$toLine.'</th>';
 $html .= '<td class="Right"><span>'.$line.'</span></td>';
 $html .= '</tr>';
}

kachar commented Oct 21, 2013

PR in #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment