Fix #11862 FP truncLongCastAssignment with increment (danmar#5290)

chrchr-github · Aug 3, 2023 · 5ff8955 · 5ff8955
1 parent da6c39e
commit 5ff8955
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/checktype.cpp b/lib/checktype.cpp
@@ -317,7 +317,7 @@ void CheckType::checkLongCast()
 
     // Assignments..
     for (const Token *tok = mTokenizer->tokens(); tok; tok = tok->next()) {
-        if (tok->str() != "=" || !Token::Match(tok->astOperand2(), "*|<<"))
+        if (tok->str() != "=" || !Token::Match(tok->astOperand2(), "*|<<") || tok->astOperand2()->isUnaryOp("*"))
             continue;
 
         if (tok->astOperand2()->hasKnownIntValue()) {

diff --git a/test/testtype.cpp b/test/testtype.cpp
@@ -367,6 +367,11 @@ class TestType : public TestFixture {
               "}\n", settings);
         ASSERT_EQUALS("[test.cpp:2]: (style) float result is returned as double value. If the return value is double to avoid loss of information, then you have loss of information.\n",
                       errout.str());
+
+        check("void f(int* p) {\n" // #11862
+              "    long long j = *(p++);\n"
+              "}\n", settings);
+        ASSERT_EQUALS("", errout.str());
     }
 
     void longCastReturn() {